(WIP): Code Editor Integration Branch #2872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4485e4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 1.87 MB ℹ️ View Unchanged
|
tsck
changed the title
tsck
changed the title
* feat(code-editor): initialize code editor package with README, configuration, and basic components * feat(code-editor): enhance CodeEditor component with new props and dependencies * refactor(code-editor): change import statements to use 'type' for CodeEditorProps * feat(code-editor): update CodeEditor stories with args and argTypes for better customization * Start test suite * Fix deps * feat(code-editor): refactor extensions handling using Compartment for dynamic configuration * feat(tests): enhance CodeEditor tests with improved selector handling and new assertions * feat(code-editor): rename 'value' prop to 'initialValue' for consistency and clarity * feat(code-editor): rename 'initialValue' prop to 'defaultValue' for consistency and update related tests * feat(code-editor): enable active line highlighting based on prop for improved editor usability * feat(tests): enable forceParsing test and update mock implementation for consistency * feat(tests): refactor CodeEditor tests to use new renderCodeEditor utility and update selectors * refactor(tests): move MutationObserver mock to testUtils for better organization * feat(docs): update README to include new CodeEditor properties and test utilities * refactor(tests): update typing test to use userEvent and export editor utilities * refactor(tests): update CodeEditor interactions and test utilities for improved clarity * test: update forceParsing method test to remove async and improve clarity * changeset * feat(docs): add CodeEditor package information to README * feat: expand exports in index.ts to include additional CodeEditor types and functions * refactor(tests): move renderCodeEditor utility to CodeEditor.testUtils for better organization * feat(tests): add TestUtils for improved test rendering utilities * fix: correct rendering description in tests and update README for CodeEditor example refactor: extract CodeMirror dimensions into constants for better maintainability docs: enhance CodeMirror types documentation with detailed descriptions chore: remove unused package from ALL_PACKAGES.ts * docs(code-editor): update README with CodeEditor example and default value * chore(package): update node engine version to >= 18.20.8 (#2868) * chore(package): update node engine version to >= 18.22.0 * chore(package): update node engine version to >= 18.20.8 * fix(package): update main and types paths in package.json * chore(package): add @lg-tools/build to devDependencies * chore(package): update build script in package.json * feat(button): add exports field for module resolution * feat(code-editor): add exports field for module resolution fix(button): remove exports field from package.json
* feat(code-editor): implement indent unit and size configuration * refactor(code-editor): reorder indent size and unit props in CodeEditorProps * Changeset * docs(code-editor): update README to include indentSize and indentUnit properties
* feat(code-editor): implement indent unit and size configuration * refactor(code-editor): reorder indent size and unit props in CodeEditorProps * feat(code-editor): add tooltip functionality with customizable content * feat(code-editor): add getAllBySelector and queryAllBySelector functions for element retrieval * feat(code-editor): add Line and Tooltip selectors to CodeEditorSelectors * feat(code-editor): enhance tooltip content handling for string and React elements * feat: add @storybook/test dependency and implement TooltipOnHover story - Updated package.json to include @storybook/test as a dev dependency. - Enhanced CodeEditor.stories.tsx with a new TooltipOnHover story to test tooltip visibility on hover. - Implemented play function to simulate mouse movement and verify tooltip appearance. * feat(code-editor): export IndentUnits and Tooltip types from CodeEditor * feat(code-editor): add tooltips property to editor and enhance selector functions * changeset * fix(code-editor): reset defaultValue to an empty string in story configuration * CR changes * docs(createTooltipExtension): update tooltip parameter descriptions to reflect one-based indexing * feat(code-editor): implement diagnostics-based tooltips in CodeEditor - Replaced the existing tooltip extension with a new diagnostics-based tooltip extension. - Updated CodeEditorTooltip interface to include severity and length properties. - Introduced CodeEditorTooltipSeverity enum for tooltip severity levels (info, warning, error, hint). - Modified the createDiagnosticsTooltipExtension function to handle multiple tooltips as diagnostics. - Updated the CodeEditor component to utilize the new tooltip extension. - Adjusted the tooltip rendering logic to support React components and strings. - Updated relevant type definitions and imports across the codebase. * refactor(code-editor): remove commented-out line for clarity
#2883) * feat(code-editor): add custom extension support * Bring lockfile in line with integration * Manually fix lock file * One more time, fix lock
tsck
force-pushed
the
integration/code-editor
branch
from
6d3229e to
4485e4d
Compare
|
No longer need draft PR open while working on integration. Will close until ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes