CDRIVER-5780 Support QE with Client.bulkWrite #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb-ad
requested review from
eramongodb and
kevinAlbs
and removed request for
eramongodb
kevinAlbs
reviewed
Jun 18, 2025
eramongodb
requested changes
Jun 18, 2025
Co-authored-by: Kevin Albertson <[email protected]>
eramongodb
approved these changes
Jul 17, 2025
| static bool | ||
| _state_need_mongo_collinfo (_state_machine_t *state_machine, bson_error_t *error) | ||
| _state_need_mongo_collinfo (_state_machine_t *state_machine, bool with_db, bson_error_t *error) |
There was a problem hiding this comment.
Can this bool with_db parameter be made char const* db_name instead?
static bool
_state_need_mongo_collinfo (_state_machine_t *state_machine, char const* db_name, bson_error_t *error)
{
...
db = mongoc_client_get_database (state_machine->collinfo_client, db_name);
... case MONGOCRYPT_CTX_NEED_MONGO_COLLINFO:
if (!_state_need_mongo_collinfo (state_machine, state_machine->db_name, error)) {
goto fail;
}
break;
case MONGOCRYPT_CTX_NEED_MONGO_COLLINFO_WITH_DB: {
char const *const db_name = mongocrypt_ctx_mongo_db (state_machine->ctx);
if (!db_name) {
_ctx_check_error (state_machine->ctx, error, true);
goto fail;
}
if (!_state_need_mongo_collinfo (state_machine, db_name, error)) {
goto fail;
}
break;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spruce.mongodb.com/version/687892c48cb17900072aac7a