CSHARP-3538: CSOT: Auth #1720
Open
CSHARP-3538: CSOT: Auth #1720
+445
−597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSHARP-3545: CSOT: MongoDB Handshake CSHARP-3548: CSOT: Server Discovery and Monitoring
sanych-sun
commented
Jul 7, 2025
| readTimeout: heartbeatSocketTimeout, | ||
| writeTimeout: heartbeatSocketTimeout | ||
| readTimeout: null, | ||
| writeTimeout: null |
There was a problem hiding this comment.
Do not have to set the timeouts on the stream level, now we are using OperationContext to enforce the timeouts.
sanych-sun
commented
Jul 7, 2025
| @@ -32,12 +31,10 @@ internal interface IConnection : IDisposable | |||
| bool IsExpired { get; } | |||
| ConnectionSettings Settings { get; } | |||
|
|
|||
| // TODO: CSOT: remove this in scope of MongoDB Handshake | |||
| void SetReadTimeout(TimeSpan timeout); | |||
There was a problem hiding this comment.
This method was used in a single place, where we were setting the timeout for streaming heartbeat. Now we are using OperationContext instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes related to multiple CSOT-related tickets: