CSHARP-5391: Add spec test for $$type operator with "number" #1739
Conversation
adelinowona
requested review from
papafe and
sanych-sun
and removed request for
a team and
papafe
tests/MongoDB.Driver.Tests/UnifiedTestOperations/Matchers/UnifiedValueMatcher.cs
Outdated
Show resolved
Hide resolved
tests/MongoDB.Driver.Tests/UnifiedTestOperations/Matchers/UnifiedValueMatcher.cs
Outdated
Show resolved
Hide resolved
|
|
||
| if (expectedTypes.IsString) | ||
| { | ||
| expectedTypeNames = new List<string> { expectedTypes.AsString }; | ||
| var expectedType = expectedTypes.AsString; |
There was a problem hiding this comment.
Instead of asserting differently in more than one place keep the existing assert at the end of this method and change how expectedTypeNames is computed:
if (expectedTypes.IsString)
{
var expectedType = expectedTypes.AsString;
expectedTypeNames = expectedType == "number" ? __numericTypes : [expectedType];
}
else if (expectedTypes.IsBsonArray)
{
expectedTypeNames = expectedTypes.AsBsonArray
.Select(t => t.AsString)
.SelectMany(t => t == "number" ? __numericTypes : [t])
.ToList();
}
else
{
throw new FormatException($"Unexpected $$type value BsonType: '{expectedTypes.BsonType}'.");
}
There was a problem hiding this comment.
I leave it to you to verify that all tests still pass with this proposed refactoring.
There was a problem hiding this comment.
Also, does "number" actually ever appear as ONE element of an array?
In the json file you are adding it always appears by itself.
So the changes to the else if part might not actually be needed...
There was a problem hiding this comment.
I decided to also modify the BsonArray case as the "number" value could be used anywhere. Currently there are no instances in our spec tests where it is used as an element of an array but in the future we could have a spec test that uses the "number" value in an array. However, it is untested functionality currently and updating the array use case in the future will be easy so I'll defer it.
No description provided.