Consider HTTP 429 a succcessful response in the Markdown link check. #2191
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
added
enhancement
review-priority-urgent
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Markdown link check configuration to properly handle HTTP 429 (Too Many Requests) responses by treating them as successful checks instead of retrying the requests.
- Replaces the retry flag
-rwith acceptable status codes flag-a 200,206,429 - Updates the comment to reflect the new approach of considering HTTP 429 as successful
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
API Change ReportNo changes found! |
prestonvasquez
approved these changes
Sep 4, 2025
This was referenced Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When checking Markdown links, if the endpoint returns HTTP 429 (Too Many Requests), consider it a successful check.
Background & Motivation
The previous attempt to fix this (#2186) didn't work. Use this approach instead.