Skip to content

Conversation

@GliczDev
Copy link

For some reason, type parameters weren't passed to fallback property codec, which caused an exception when trying to access them. Now, this issue is fixed.

@GliczDev GliczDev requested a review from a team as a code owner July 11, 2025 00:59
@GliczDev GliczDev requested review from NathanQingyangXu and removed request for a team July 11, 2025 00:59
@NathanQingyangXu
Copy link
Contributor

@rozza , I am not sure about the validity of the code changes proposed. For one thing, it breaks 6 unit testing cases; secondly it seems FallbackPropertyCodecProvider opted for calling CodecRegistry#get(Type) intentionally, for the reason that the other get(Type, List<Type>() might not be overridden, thus defeating the purpose of fallback as the last resort.
How do you think?

@rozza
Copy link
Member

rozza commented Jul 21, 2025

@GliczDev looks like this PR needs some tests and as @NathanQingyangXu mentioned this does appear to break some existing test cases.

To run the bson tests and checks run ./gradlew bson:check from the shell.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of requested changes - to support java 8+ and to ensure that types are only provided if the list is not empty.

The LookupCountingCodecRegistry implementation in tests will need to implement <T> Codec<T> get(Class<T> clazz, List<Type> typeArguments) inorder not to throw an exception.

eg:

@Override
public <T> Codec<T> get(final Class<T> clazz, final List<Type> typeArguments) {
        incrementCount(clazz);
        for (CodecProvider provider : codecProviders) {
            Codec<T> codec = provider.get(clazz, typeArguments, this);
            if (codec != null) {
                return codec;
            }
        }
        return null;
}

It would also be good to add a regression test where this code path is used.

@GliczDev
Copy link
Author

GliczDev commented Nov 2, 2025

It would also be good to add a regression test where this code path is used.

@rozza I'm sorry, I'm not familiar with mongo-java-driver project structure and tests really. Could you point me where I should add things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants