Skip to content

RUST-2304 Add workarounds for bulk write server bugs #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isabelatkinson merged 2 commits into from
Dec 9, 2025
Merged

RUST-2304 Add workarounds for bulk write server bugs #1551

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3529c7d
add nModified default
isabelatkinson Dec 5, 2025
3a1f514
optimization
isabelatkinson Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions driver/src/operation/bulk_write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,12 @@ where
n_modified,
upserted,
} => {
// small optimization for SERVER-113344: if the server unexpectedly returns a
// success response for an errors-only bulk write, skip deserializing the individual
// response, as the call to add_*_result will be a no-op
if R::errors_only() {
return Ok(());
}
let model = self.get_model(response.index)?;
match model.operation_type() {
OperationType::Insert => {
Expand All @@ -183,12 +189,8 @@ where
result.add_insert_result(index, insert_result);
}
OperationType::Update => {
let modified_count =
n_modified.ok_or_else(|| ErrorKind::InvalidResponse {
message: "nModified value not returned for update bulkWrite \
operation"
.into(),
})?;
// default to 0 as a workaround for SERVER-113026
let modified_count = n_modified.unwrap_or(0);
let update_result = UpdateResult {
matched_count: n,
modified_count,
Expand Down