Skip to content

[OIDC] Add missing pr comment resolution #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

anandsyncs
Copy link
Contributor

Summary

Related to this comment on the OIDC test PR.
#55 (comment)

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@anandsyncs anandsyncs requested a review from a team as a code owner June 5, 2025 14:41
@anandsyncs anandsyncs changed the title Add missing pr comment resolution [OIDC ]Add missing pr comment resolution Jun 5, 2025
@anandsyncs anandsyncs changed the title [OIDC ]Add missing pr comment resolution [OIDC] Add missing pr comment resolution Jun 5, 2025
@anandsyncs anandsyncs merged commit febd854 into master Jun 8, 2025
35 checks passed
@anandsyncs anandsyncs deleted the anandsingh/fix-missed-oidc-pr-comment branch June 8, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants