CLOUDP-323997: Split mongodb_types into smaller files #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julien-Ben
changed the title
# Conflicts: # api/v1/mdb/mongodb_types.go
Julien-Ben
force-pushed
the
refactor-mdb-types
branch
from
3dcf495 to
72a1c54
Compare
This reverts commit 6867e5c.
Julien-Ben
force-pushed
the
refactor-mdb-types
branch
from
3839dd6 to
41697c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the
mongodb_types.gohaving over 1700 lines of code, I propose we split it into smaller files.I identified 3 "groups": security, agent config and backup.
Proof of Work
No functional changes, e2e must pass.