Tag latest readiness and versionhook when building on master #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
reviewed
Jun 23, 2025
| @@ -1007,8 +1007,24 @@ def build_image_generic( | |||
| # But since we don't run daily rebuilds on ecr image builds, we can do that step instead here. | |||
| # We only need to push manifests for multi-arch images. | |||
| create_and_push_manifest(registry_address, version, architectures=architectures) | |||
| latest_tag = "latest" | |||
| if not is_running_in_patch() and is_running_in_evg_pipeline(): | |||
| logger.info(f"Tagging and pushing {registry_address}:{version} as {latest_tag}") | |||
There was a problem hiding this comment.
q: do you think this as an attribute and trace is useful? Consider the cross-patches query-ability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is another attempt at publishing latest tags of readiness probes and versionhooks from CI after master merges. The previous attempt (#57) was unsuccessful and was reverted.
This problem affects multi-arch images as they're not using sonar and have multi-arch manifests pushed after sonar build in
pipeline.py. Single-arch images have latest images published via sonar inventoryCurrent approach adds logic checking if we're not building from a patch (from PR or manually triggered evg pipeline) and in evg:
Proof of Work
Manual test
It's difficult to trigger "master" build from PR, so a manual test was performed by changing the condition [here] (https://github.com/mongodb/mongodb-kubernetes/pull/205/files#diff-6b92e3e77956f8020482ca91889a24f3411c9a4854f2aaaac30ee504ef26ede4R1012) with changed tag to
latest-testWe can see
latest-testpushed hereBuild from PR
When building from PR it's not pushing tag: evg
The final test will be performed after merging.
Checklist
Reminder (Please remove this when merging)