-
Notifications
You must be signed in to change notification settings - Fork 11
fixing context image not created when manually running releases #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
commented
Jun 30, 2025
@@ -8,9 +8,9 @@ metadata: | |||
certified: "true" | |||
containerImage: quay.io/mongodb/mongodb-kubernetes:1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should go away with this: #210
nammn
commented
Jun 30, 2025
mircea-cosbuc
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added some suggestions to avoid confusion later when revisiting the code.
anandsyncs
approved these changes
Jun 30, 2025
Co-authored-by: mircea-cosbuc <[email protected]>
…ix-agent-image-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes several updates to improve code readability, streamline imports, and enhance observability in the
mongodb-kubernetes
project. The changes encompass YAML file formatting, Python test import simplifications, and additional tracing attributes in the pipeline logic.Pipeline Enhancements:
should_skip_arm64
function inpipeline.py
to accept aBuildConfiguration
parameter. Otherwise - we are skipping arm64 releases during manually triggered releasesget_architectures_set
,inner
, andbuild_image_generic
functions, improving observability. [1] [2] [3].Proof of Work
Checklist
Reminder (Please remove this when merging)