Skip to content

CLOUDP-321072: set minimum mongodb search version support at 8.2.0 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: search/public-preview
Choose a base branch
from

Conversation

anandsyncs
Copy link
Contributor

@anandsyncs anandsyncs commented Jul 14, 2025

Summary

This pull request refactors the version validation logic for MongoDB in MongoDBSearch to improve reusability and updates the minimum required MongoDB version to 8.2.0. It also updates the corresponding test cases to reflect these changes.

Proof of Work

Tests pass

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@anandsyncs anandsyncs marked this pull request as ready for review July 14, 2025 12:51
@anandsyncs anandsyncs requested a review from a team as a code owner July 14, 2025 12:51
@anandsyncs anandsyncs requested review from m1kola and MaciejKaras July 14, 2025 12:51
@anandsyncs anandsyncs marked this pull request as draft July 14, 2025 12:51
@anandsyncs anandsyncs changed the base branch from master to search/public-preview July 14, 2025 12:52
@anandsyncs anandsyncs changed the title set minimum mongodb search version support at 8.2.0 CLOUDP-321072: set minimum mongodb search version support at 8.2.0 Jul 14, 2025
Copy link
Contributor

@fealebenpae fealebenpae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but let's park it for now until we can get our hands on 8.2 images.

@MaciejKaras MaciejKaras removed their request for review July 15, 2025 06:44
@anandsyncs anandsyncs marked this pull request as ready for review July 17, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants