-
Notifications
You must be signed in to change notification settings - Fork 11
wip - refactor - agent matrix work #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nammn
wants to merge
27
commits into
master
Choose a base branch
from
remove-agent-matrix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d76eda3
to
08c2c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces significant changes to the MongoDB operator codebase, focusing on improving the handling of static and non-static architectures, simplifying configuration, and updating tests to reflect the new architecture. The most important changes are grouped into architecture handling, configuration updates, and test adjustments.
Architecture Handling:
buildStaticArchitecturePodTemplateSpec
andbuildNonStaticArchitecturePodTemplateSpec
indatabase_construction.go
).Configuration Updates:
InitDatabaseNonStaticImage
toInitDatabaseImage
inDatabaseStatefulSetOptions
for clarity and consistency. [1] [2]ShareProcessNamespace
by using a pointer utility function (ptr.To(true)
) instead of manually creating a boolean pointer.Test Adjustments:
Code Cleanup:
versionutil
import and associated logic for appending the operator version to the agent version. [1] [2]Miscellaneous:
Proof of Work
Checklist
Reminder (Please remove this when merging)