CLOUDP-331496: Remove undocumented operator.enablePVCResize Helm value
#272
+63
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MaciejKaras
approved these changes
Jul 18, 2025
lsierant
reviewed
Jul 21, 2025
| @@ -4,7 +4,7 @@ | |||
| # MCK 1.3.0 Release Notes | |||
|
|
|||
| ## Other Changes | |||
| * Optional permissions for `PersistentVolumeClaim` moved to a separate role. When managing the operator with Helm it is possible to disable permissions for `PersistentVolumeClaim` resources by setting `operator.enablePVCResize` value to `false` (`true` by default). When enabled, previously these permissions were part of the primary operator role. With this change, permissions have a separate role. | |||
| * The undocumented `operator.enablePVCResize` Helm value has been removed. If you previously set this value to `false`, please note that the operator roles will now include permissions for `PersistentVolumeClaim` resources by default. | |||
There was a problem hiding this comment.
This should be considered a breaking change, so requiring bumping major version...
There was a problem hiding this comment.
Arguably it is not a breaking change since we are adding new RBAC by default. Yes, we are removing the setting which only appears in values.yaml, but at runtime it won't negatively affect the operator or workloads.
lsierant
requested changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #260 I moved
PersistentVolumeClaimpermissions into a separate role, enabling modularity because these permissions are controlled byoperator.enablePVCResizeHelm value and appeared to be optional.Later I noticed that
operator.enablePVCResizeis undocumented.I propose that we revert changes done in #260 and remove the undocumented setting. Permissions are enabled by default already and I do not think there is a rationale for this to be configurable.
Furthermore - we do not test this with
operator.enablePVCResizeset tofalse. We don't even know if the operator will still function correctly without the permissions.Proof of Work
N/A - CI must be green.
Checklist
Reminder (Please remove this when merging)