[CLOUDP-332234] Change the way kubectl-mongodb plugin is built by evergreen function #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster This commit moves the source code of mongodb kubectl plugin from `public/tools/multicluster` to `cmd` directory. This is to align with how go code that ships a CLI is structured. The command/subcommand building logic is moved to the `cmd` directory and and rest of the logic The command/subcommand building logic is moved to the `cmd` directory and and rest of the logic is moved to the new package `pkg/kubectl-mongodb`. This commit also moves the `.goreleaser.yaml` to the root of the project because kubectl plugin is now at the root of the project.
1. Since most of our evergreen config files are in root of the repo and now that kubectl plugin is also moved to `cmd/` it makes sense to move the evergreen config file to the root of repo with correct name. 2. Change the goreleaser config file to version 1. We upgraded it temporarily to version 2 but CI complains that only version 1 is supported.
The evergreen function `build_multi_cluster_binary` is used to build the `kubectl-mongodb` plugin. And this function gets used in the main `.evergreen.yml` file to build the `kubectl-mongodb` binary. Since we moved the location of the source files for `kubectl-mongodb` plugin as part of [PR](#271), this PR makes respective changes in the evergreen function so that it can properly build the `kubectl-mongodb` plugin from the new location.
viveksinghggits
requested review from
m1kola and
MaciejKaras
and removed request for
a team
|
@viveksinghggits is this PR ready for review? I cannot see PoW and evergreen pipeline is not running (probably you need to change PR base). If this is not ready, please move it back to draft. Otherwise engineers are automatically assigned and notified about awaiting PR |
3 tasks
viveksinghggits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The evergreen function
build_multi_cluster_binaryis used to build thekubectl-mongodbplugin. And this function gets used in the main.evergreen.ymlfile to build thekubectl-mongodbbinary. Since we moved the location of the source files forkubectl-mongodbplugin as part of PR, this PR makes respective changes in the evergreen function so that it can properly build thekubectl-mongodbplugin from the new location.Proof of Work
ToDo:
Jira: https://jira.mongodb.org/browse/CLOUDP-332234
Checklist
Reminder (Please remove this when merging)