CLOUDP-333692: Re-design images building #303
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.2.1 Release NotesOther Changes
|
Julien-Ben
force-pushed
the
julienben/redesign-pipeline
branch
from
d7ae339 to
6649987
Compare
Fix build scenario Remove create and push manifests Continue improvement to main Simplify main and build_context missed Pass Build Configuration object directly Use legacy and new pipeline Fix Remove --include Rename MCO test image Multi platform builds, with buildx TODOs Implement is_release_step_executed() Fix init appdb image Import sort black formatting Some cleaning and version adjustments Adapt main to new build config Add buildscenario to buildconfig Handle build env Renaming, usage of high level config All images build pass on EVG Lint Explicit image type, support custom build_path Replace old by new pipeline in EVG Add documentation Split in multiple files, cleanup WIP, passing builds on staging temp + multi arch manifests Replace usage of sonar Remove namespace Remove pin_at and build_id Copied pipeline, removed daily builds and --exclude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Re-design images building
Changes
Usage of standalone Dockerfiles
Added in a previous PR, they eliminate the need for templating, and make it possible to retire Sonar once the Epic is completed.
Building with docker buildx, multi-platform builds
In
build_images.pywe use docker buildx through a python API. It eliminates the need for building images separately for each platform, and manually bundling them in a manifest.Handle build environments explicitly,
Each build scenario, such as merge to master or a local patch, is handled and defined explicitly, at top level, in the main.py CLI. All options are inferred from the environment as before, but can be overridden through flags.
They define parameters such as registry, image tag, signing enabled ...
Proof of work
CI
Note
For the duration of the Atomic Releases epic, both pipelines will be in the repository, until we are done with the staging and promotion process. This new pipeline will only be used for Evergreen patches.
The existing Evergreen function, that uses
pipeline.pyhas been renamedlegacy_pipeline, and is used for release and periodic builds tasks.A new one has been created, using the new pipeline.
Once the Atomic Release Epic is complete, we'll be able to remove:
pipeline.pyChecklist
skip-changeloglabel if not needed