-
Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP-317663: Archive snippets outputs instead of comitting #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d495a2a to
946ef97
Compare
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
946ef97 to
7122dd8
Compare
7122dd8 to
5d53e89
Compare
5d53e89 to
8ca9eb0
Compare
7b24ec1 to
ba0e494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
Couple of questions though:
- I see in the code that we are uploading code_snippets output for every patch, including PRs etc. Do we actually need to upload code snippets for PRs? Do we have a cleanup mechanism in S3 for this?
- update_docs_snippets.sh needs to be run manually, right?
Good catch! Indeed, we should only upload in public flavors!
Yes, for now it's for manual run. I assume automation will be done as part of Atomic Releases. |
No, it's correct. Outputs are uploaded to s3 as part of evergreen artifacts for every run and this is by design. Wrt cleanup - it's being cleaned up according to the artifacts bucket - after 90 days or so. |
Summary
With this PR we will no longer commit snippets outputs back to the repo and just archive them to s3 instead.
Additionally,
scripts/dev/update_docs_snippets.shscripts was updated. But automated snippets updates from CI runs are not part of this PR.When reviewing collapse changes to tests/output directory - all those files (previously comitted outputs) were just deleted.

Proof of Work
Archiving outputs to s3
manual evg run
locally executed update script
Branch was automatically pushed with all gathered snippets and outputs:
https://github.com/10gen/docs-mongodb-internal/compare/MCK-snippets-update-69038706b0fce50007f25a9d?expand=1