-
Notifications
You must be signed in to change notification settings - Fork 21
[CLOUDP-350567] Automate PR creation to release helm chart using gh helm repo #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MCK 1.6.0 Release NotesNew Features
Bug Fixes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code generally looks good, but I have two general comments:
- instead of logging error and returning the error code, it's easier to just repackage the error and raise it again:
except GithubException as e:
raise Exception(f"ERROR: Could not create Pull Request. GitHub API returned an error: {e.status}, details: {e.data}, original error: {e}")
- the main method does a little too much. It should only handle flags parsing and validation. After that call nested method with validated args that does the hard work.
1. Make main smaller 2. Handle exceptions better
a716bdd
to
c09f4c4
Compare
Hi @MaciejKaras, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Nice work, great to see this automated eventually! 💪
Hi @m1kola @Julien-Ben , |
1. Change info to debug 2. Specify types of arguments in run_command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nit, but it's so great to have this automation ! Well done 👏
Summary
Per current process when we try to release a version of the helm chart we create a PR to the
mongodb/helm-charts
repo. Since this is manual task, it's time consuming and error prone.This PR tries to automate that manual task.
Proof of Work
The successful run here created the PR on helm chart repo successfully.
Checklist
skip-changelog
label if not needed