-
Notifications
You must be signed in to change notification settings - Fork 22
CLOUDP-339241 - Improve e2e on arm #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ddf1f1b
18ed11f
9d5289b
16d9f66
cd155af
f11312f
8e3051a
15dc9e1
f918af6
3f47fab
c403c7f
503094f
fc6c402
39ef0f7
c80d9fb
3b48764
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ | |
INIT_DATABASE_IMAGE, | ||
INIT_OPS_MANAGER_IMAGE, | ||
MCO_TESTS_IMAGE, | ||
MEKO_TESTS_ARM64_IMAGE, | ||
MEKO_TESTS_IMAGE, | ||
OPERATOR_IMAGE, | ||
OPERATOR_RACE_IMAGE, | ||
|
@@ -69,6 +70,7 @@ def get_builder_function_for_image_name() -> Dict[str, Callable]: | |
|
||
image_builders = { | ||
MEKO_TESTS_IMAGE: build_meko_tests_image, | ||
MEKO_TESTS_ARM64_IMAGE: build_meko_tests_image, | ||
OPERATOR_IMAGE: build_operator_image, | ||
OPERATOR_RACE_IMAGE: partial(build_operator_image, with_race_detection=True), | ||
MCO_TESTS_IMAGE: build_mco_tests_image, | ||
|
@@ -120,6 +122,12 @@ def image_build_config_from_args(args) -> ImageBuildConfiguration: | |
platforms = get_platforms_from_arg(args.platform) or image_build_info.platforms | ||
sign = args.sign if args.sign is not None else image_build_info.sign | ||
skip_if_exists = args.skip_if_exists if args.skip_if_exists is not None else image_build_info.skip_if_exists | ||
architecture_suffix = ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: can you switch the condition to be exactly the same as the previous args? It helps with reading what will happen as you already understand the previous pattern There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch, not sure how I missed that |
||
args.architecture_suffix if args.architecture_suffix is not None else image_build_info.architecture_suffix | ||
) | ||
|
||
if architecture_suffix and len(platforms) > 1: | ||
raise ValueError("Cannot use architecture suffix with multi-platform builds") | ||
|
||
# Validate version - only agent can have None version as the versions are managed by the agent | ||
# which are externally retrieved from release.json | ||
|
@@ -140,6 +148,7 @@ def image_build_config_from_args(args) -> ImageBuildConfiguration: | |
parallel_factor=args.parallel_factor, | ||
all_agents=args.all_agents, | ||
currently_used_agents=args.current_agents, | ||
architecture_suffix=architecture_suffix, | ||
) | ||
|
||
|
||
|
@@ -283,6 +292,11 @@ def main(): | |
action="store_true", | ||
help="Build all currently used agent images.", | ||
) | ||
parser.add_argument( | ||
"--architecture-suffix", | ||
action=argparse.BooleanOptionalAction, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is great, I was not aware of this option! moving away from |
||
help="Append architecture suffix to image tags for single platform builds. Can be true or false. This will override the value from build_info.json", | ||
) | ||
|
||
args = parser.parse_args() | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a quick fix for the intermittent failure of
download_kube_tools
function