-
Notifications
You must be signed in to change notification settings - Fork 21
Add new cluster types to telemetry #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MCK 1.6.0 Release NotesNew Features
Bug Fixes
|
openshift = "Openshift" | ||
rke = "RKE" | ||
rke2 = "RKE2" | ||
evg = "Evergreen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for those new flavours in TestDetectKubernetesFlavour
(+ already missing ones 🙏 )
evg = "Evergreen" | ||
minikube = "Minikube" | ||
k3s = "K3s" | ||
microk8s = "MicroK8s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing the context around adding these, where does this requirement come from?
If we want to cover all the possible flavors then there are some names still missing.
Summary
This extends the cluster types we recognize in telemetry. Especially added a label for the kind clusters we create. This is to detect if we start sending data to prod telemetry.
Proof of Work
Checklist
skip-changelog
label if not needed