feat(NODE-7150)!: update peer dependency matrix for 3rd party peer deps #4720
+26
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjik1
added
the
Primary Review
tadjik1
reviewed
Oct 9, 2025
tadjik1
reviewed
Oct 9, 2025
Comment on lines
-33
to
-39
| "@aws-sdk/credential-providers": "^3.188.0", | ||
| "@mongodb-js/zstd": "^1.1.0 || ^2.0.0", | ||
| "gcp-metadata": "^5.2.0", | ||
| "@aws-sdk/credential-providers": "^3.806.0", | ||
| "@mongodb-js/zstd": "^2.0.0", | ||
| "gcp-metadata": "^7.0.1", | ||
| "kerberos": "^2.0.1", | ||
| "mongodb-client-encryption": "^7.0.0-alpha", | ||
| "snappy": "^7.3.2", | ||
| "socks": "^2.7.1" |
There was a problem hiding this comment.
I have a general question here. I've noticed that the versions for these packages in our devDependencies are out of sync with the versions being updated in this PR:
@aws-sdk/credential-providers: ^3.876.0 - newer
gcp-metadata: ^5.3.0 - older (2 major versions)
snappy: ^7.3.2 - newer (minor)
socks: ^2.8.7 - newer (minor)
To ensure the driver works as expected, shouldn't we update the devDependencies to match these new versions? This would align our testing environment with what our users will be running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript