test(NODE-5206): fix flaky sdam prose test #4752
Conversation
| const events: string[] = []; | ||
| beforeEach(async function () { | ||
| client = this.configuration.newClient({ | ||
| directConnection: true, | ||
| appName: 'SDAMPoolManagementTest', | ||
| heartbeatFrequencyMS: 500 | ||
| heartbeatFrequencyMS: 100 |
There was a problem hiding this comment.
Spec says 500 or less, so I changed it to 100 to speed up the test.
| }); | ||
| utilClient = this.configuration.newClient({ directConnection: true }); |
There was a problem hiding this comment.
Our general pattern in tests is to have a util client for setting fail points, so I changed this in this test.
baileympearson
added
the
Primary Review
I have no idea, but locally I could only get it to flake with the stable API enabled. Not limited to latest server as I'm on 8.0 locally, but I could not get the test to fail without the stable API enabled. And it was only one excessive failing hearbeat in the way no matter how much I tinkered with the heartbeat frequency. |
2 participants
Description
Fixes the flaky SDAM prose test for connection pooling.
Summary of Changes
Updates the test to filter out rogue server heartbeat failed events.
What is the motivation for this change?
NODE-5206
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript