Skip to content

chore(NODE-6945): remove dependency on v8-heapsnapshot #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2025
Merged

chore(NODE-6945): remove dependency on v8-heapsnapshot #4763

merged 4 commits into from
Oct 30, 2025
+19 −27

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 29, 2025 •
edited
Loading

Description

Summary of Changes

This PR

  • Modifies the MongoClient leak tests to use v8.queryObjects() instead of v8-heapsnapshot (experimental, available in all Nodejs runtimes we support).
  • Remove v8-heapsnapshot from our dependencies

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review October 30, 2025 15:32
@baileympearson baileympearson requested a review from a team as a code owner October 30, 2025 15:32
@durran durran self-assigned this Oct 30, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 30, 2025
durran
durran approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this refactor. Nice job.

@durran durran merged commit ec996e6 into main Oct 30, 2025
25 of 27 checks passed
@durran durran deleted the NODE-6945 branch October 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baileympearson @durran