wip feat(NODE-7122): exponential backoff between retries in convenient transaction API #4765
+111
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await client.connect(); | ||
|
|
||
| await configureFailPoint(this.configuration, { | ||
| configureFailPoint: 'failCommand', |
There was a problem hiding this comment.
Do we need a version check around these tests?
From #4759 (comment)
failCommand requires 4.4+ servers
There was a problem hiding this comment.
Eventually yes. This PR is a work in progress (sorry if that wasn't clear, we usually mark PRs like this as WIP in the title and add the label). This won't merge for while yet (the design isn't finished, and then the spec needs to be implemented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript