Skip to content

doc: Referenced correct stream security protocol #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Calvinnix
Copy link

Description

The protocols mentioned in the docs should be the SASL variants. i.e. PLAINTEXT -> SASL_PLAINTEXT and SSL -> SASL_SSL

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@Calvinnix Calvinnix requested a review from a team as a code owner April 28, 2025 14:59
Copy link
Contributor

github-actions bot commented May 4, 2025

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label May 4, 2025
@Calvinnix
Copy link
Author

bump

@github-actions github-actions bot removed the stale label May 6, 2025
@Calvinnix Calvinnix changed the title STREAMS-1730: reference correct stream security protocols doc: Referenced correct stream security protocol May 6, 2025
@Calvinnix Calvinnix requested a review from a team as a code owner May 6, 2025 13:09
@Calvinnix
Copy link
Author

Calvinnix commented May 6, 2025

I get the same parse error on the master branch so I'm not sure if this is a Github permission issue.

terraform-provider-mongodbatlas (master)$ go test ./internal/service/streamconnection ./internal/service/streaminstance ./internal/service/streamprocessor ./internal/service/streamprivatelinkendpoint -run '^Test(Acc|Mig)' -v -parallel 50  -timeout  -ldflags="-s -w -X 'github.com/mongodb/terraform-provider-mongodbatlas/version.ProviderVersion=35bb7b7'"                                                
invalid value "-ldflags=-s -w -X 'github.com/mongodb/terraform-provider-mongodbatlas/version.ProviderVersion=35bb7b7'" for flag -timeout: parse error
usage: go test [build/test flags] [packages] [build/test flags & test binary flags]
Run 'go help test' and 'go help testflag' for details.

EDIT: This won't succeed because it doesn't have a -timeout arg provided. These pass locally when I provide it a valid timeout arg e.g. 10s

Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lmkerbey-mdb lmkerbey-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants