Merge pull request #36 from Sebmaster/fix/nulled-array

Fix errors on null value array types
mongoosejs · Aug 4, 2024 · b1b7265 · b1b7265
2 parents 32e828a + 2553f51
commit b1b7265
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -124,16 +124,17 @@ function applyGettersToDoc(schema, doc, fields, prefix) {
 
     const pathExists = mpath.has(path, doc);
     if (pathExists) {
-      if (schematype.$isMongooseArray && !schematype.$isMongooseDocumentArray) {
+      const val = schematype.applyGetters(mpath.get(path, doc), doc, true);
+      if (val && schematype.$isMongooseArray && !schematype.$isMongooseDocumentArray) {
         mpath.set(
           path,
-          schematype.applyGetters(mpath.get(path, doc), doc, true).map(subdoc => {
+          val.map(subdoc => {
             return schematype.caster.applyGetters(subdoc, doc);
           }),
           doc
         );
       } else {
-        mpath.set(path, schematype.applyGetters(mpath.get(path, doc), doc, true), doc);
+        mpath.set(path, val, doc);
       }
     }
   });

diff --git a/test/index.test.js b/test/index.test.js
@@ -45,6 +45,22 @@ describe('mongoose-lean-getters', function() {
     assert.equal(doc.arr[0].test, 'baz');
   });
 
+  it('with nulled array', async function() {
+    const schema = mongoose.Schema({
+      arr: [String]
+    });
+    schema.plugin(mongooseLeanGetters);
+
+    const Model = mongoose.model('withNulledArray', schema);
+
+    await Model.deleteMany({});
+    await Model.create({ arr: null });
+
+    const doc = await Model.findOne().lean({ getters: true });
+
+    assert.equal(doc.arr, null);
+  });
+
   it('only calls getters once with find() (gh-1)', async function() {
     const schema = mongoose.Schema({
       name: {