Fix dashboard result rendering #73
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes dashboard result rendering issues by ensuring proper component remounting and fixing array iteration bugs. The changes address component lifecycle management and correct variable references in template loops.
- Adds a key prop to force remounting of dashboard-result component when evaluation completes
- Fixes incorrect variable references in v-for loop within dashboard-result component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/dashboard/dashboard.html | Adds key prop to dashboard-result component for proper remounting |
| frontend/src/dashboard-result/dashboard-result.html | Fixes v-for loop variable references and adds key prop |
| class="bg-white shadow-sm ring-1 ring-gray-900/5 sm:rounded-xl" | ||
| :is="getComponentForValue(res)" | ||
| :value="res"> | ||
| :is="getComponentForValue(el)" |
There was a problem hiding this comment.
The variable 'res' was incorrectly used instead of 'el' in the original code. This fix correctly uses the loop variable 'el' to match the v-for iteration.
Copilot uses AI. Check for mistakes.
| :is="getComponentForValue(res)" | ||
| :value="res"> | ||
| :is="getComponentForValue(el)" | ||
| :value="el"> |
There was a problem hiding this comment.
The variable 'res' was incorrectly used instead of 'el' in the original code. This fix correctly uses the loop variable 'el' to match the v-for iteration.
Copilot uses AI. Check for mistakes.
Summary
Testing
npm test(fails: Timeout of 2000ms exceeded)https://chatgpt.com/codex/tasks/task_e_6882a0b48cb48324b1a41eec9706ff19