Adds clang 19 support #1942
Open
Adds clang 19 support #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree company="Verge Aero" |
|
Thanks so much, very nice work. We need to upgrade the CI binary packages as well, that's taken care of by some explicit actions, I'll get them running shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the latest msvc requires Clang >= 19, I went ahead and updated the parser to accomodate the API changes. It compiles and the tests do pass locally on windows. Unsure of the other platforms.
Addresses the issue here
I did use the LLVM commit referenced in that issue [cd70802]
Although I'm actively using CppSharp to a high degree success, this is my first direct dive into LLVM or the CppSharp codebase so I'd be happy to work through any suggested changes.