Implement SkCanvas::SaveLayerRec #2962
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Not sure my magic with CI is working with the auto detection of the skia branch (probably because I am not doing it right for forks) so maybe just update the submodule here and we can merge in one go later once the skia PR is merged. |
mattleibow
reviewed
Aug 20, 2024
| @@ -1066,4 +1076,13 @@ public void Restore () | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| [Flags] | |||
| public enum SKSaveLayerFlags | |||
There was a problem hiding this comment.
Suggested change
| public enum SKSaveLayerFlags | |
| public enum SKCanvasSaveLayerFlags |
| @@ -68,6 +68,16 @@ public int SaveLayer (SKPaint paint) | |||
| return SkiaApi.sk_canvas_save_layer (Handle, null, paint == null ? IntPtr.Zero : paint.Handle); | |||
| } | |||
|
|
|||
| public int SaveLayer (SKRect bounds, SKPaint paint, SKImageFilter backdrop, SKSaveLayerFlags saveLayerFlags = SKSaveLayerFlags.None) | |||
There was a problem hiding this comment.
Would it be worth creating a rec struct now instead of adding overloads? The next skia update will have a filters list and a color space, so reducing the new things to a new property may be nicer.
public struct SKCanvasSaveLayerRec
{
public SKRect? Bounds { get; set; }
public SKPaint? Paint { get; set; }
public SKImageFilter? Backdrop { get; set; }
public SKCanvasSaveLayerFlags { get; set; }
}Then in the save layer we can "unpack" this struct and pass it as the single C function. This way we don't need to create yet another overload to the save layer world just to add colorspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement SkCanvas::SaveLayerRec
Bugs Fixed
API Changes
Added:
int SKCanvas.SaveLayer(SKRect bounds, SKPaint paint, SKImageFilter backdrop, SKSaveLayerFlags saveLayerFlags = SKSaveLayerFlags.None)int SKCanvas.SaveLayer(SKRect bounds, SKPaint paint, SKSaveLayerFlags saveLayerFlags)Behavioral Changes
None.
Required skia PR
mono/skia#130
PR Checklist