Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow intercept of touch event #953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FoggyFinder
Copy link
Contributor

Description of Change

Added call to RequestDisallowInterceptTouchEvent.

Tests aren't provided - not sure is it required.

Bugs Fixed

Fixed: #937

shfb

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

charlesroddie
charlesroddie previously approved these changes Sep 7, 2019
@charlesroddie
Copy link

Changes look good to me. @mattleibow can you take a quick look and merge if OK?

And when this is merged, can SkiaSharp(.Views.Forms) be released? Last release was 9 months ago: is there a problem in master preventing releases?

@charlesroddie
Copy link

Can this be pushed into 1.68.1 @mattleibow ?

@FoggyFinder
Copy link
Contributor Author

just curious when it will be a turn of the PR to get some feedback/decision

@charlesroddie
Copy link

@mattleibow

@mattleibow
Copy link
Contributor

Sorry about the delay folks, I was busy getting things working again and then fixing a few issues.
But, I think we are good now so I'll have a look at this PR now ad see if we can get it in 1.68.1.

@mattleibow
Copy link
Contributor

mattleibow commented Nov 14, 2019

Moved comment to issue: #937 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Android] Dissalow further propagation for touch events
3 participants