Update skia to milestone 119 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used in a followup to handle SkSL test filtering. Change-Id: Ia0886035aa24def8f9455d8b106bf79d24483b34 Bug: b/40044139 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757216 Commit-Queue: John Stiles <[email protected]> Reviewed-by: Jim Van Verth <[email protected]>
Some GMs were trying to test for recording backends by calling:
canvas->getSurface()
... surprisingly, this was returning nullptr on CPU configs, because we
were using the canvas-from-bitmap constructor.
Change-Id: Ic343c3ae9470479911f33cb5c248e261345175f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757018
Reviewed-by: John Stiles <[email protected]>
Auto-Submit: Brian Osman <[email protected]>
Commit-Queue: Brian Osman <[email protected]>
Reviewed-by: Jim Van Verth <[email protected]>
We no longer have a Dawn Ganesh backend. Bug: b/40045010 No-Try: true Change-Id: I54d54df6dff4ff352762fd07f6f6a80fb2649947 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757396 Commit-Queue: John Stiles <[email protected]> Auto-Submit: John Stiles <[email protected]> Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Kevin Lubick <[email protected]>
This reverts commit bcf2206. Reason for revert: Fix iterator invalidation Original change's description: > Revert "[skicu] Use cache and respect locale" > > This reverts commit 7cafb62. > > Reason for revert: Test-Debian10-Clang-GCE-CPU-AVX2-x86_64-Debug-All-NativeFonts > > Original change's description: > > [skicu] Use cache and respect locale > > > > Change-Id: I2154f9f978629e00a2a67e8838804e381b1f4d43 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/748457 > > Commit-Queue: Ben Wagner <[email protected]> > > Reviewed-by: Julia Lavrova <[email protected]> > > Change-Id: I34e63fe76b88ecbc3a6fcdc25a2b11b56584f87f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755037 > Auto-Submit: Ben Wagner <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> Change-Id: I8c3bc2a4a962d3e9ac4b5d5c048ec8fa676b327f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/754877 Commit-Queue: Ben Wagner <[email protected]> Reviewed-by: Brian Osman <[email protected]>
Change-Id: Ib832a7ee127aedb56f99a0cacd1bf5a146eb5cd8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756397 Reviewed-by: John Stiles <[email protected]> Commit-Queue: Brian Osman <[email protected]>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/debugger-app-base-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I79d66d06fa1a39f8e334e7fdb6a76c432fec8479 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756943 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jsfiddle-base-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I19eeced45093b7d4d8bda27c09d1cc56f3e2863e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756984 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skottie-base-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Id42644264e7fe1170a6a0601678647a6d3e263fb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756944 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaders-base-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I5b9655d3b8367d307ef5d4ed73ffdba905a8d5fa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756945 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Includes a comment explaining the rationale. Note that the previous code was actually *wrong*, too. We were treating the color as originally premul (it wasn't), and transforming to an unknown alpha type, which would have confused any code using it. Change-Id: I7f6c3dad84944ba4ab47c0776f400dbb1a0a1f07 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757336 Reviewed-by: John Stiles <[email protected]> Commit-Queue: Brian Osman <[email protected]>
We had a Ganesh-specific test-disable inside of a
`b.extraConfig("Graphite")` if block; we shouldn't be
running any Ganesh tests at all when Graphite is enabled.
Change-Id: Id192dd2b5c4c862a35fd416bcdd83d7b7fc9a8ce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757536
Reviewed-by: Kevin Lubick <[email protected]>
Commit-Queue: Kevin Lubick <[email protected]>
Auto-Submit: John Stiles <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/cf45d7c5dc0d..293f55f6d3d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I5bc735db199aac12e3f8828c67dff8ad5aaf0f0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756953 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/aea31dd66eb1..1b17251d0e2c 2023-09-18 [email protected] Add Skia Perf configs for WebRTC instances. 2023-09-18 [email protected] Preserve log trace when there is only one error 2023-09-18 [email protected] Use skerr.Wrap more in httputils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/sk-tool-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ia16357d5c1cdc96a211c4e043b9090498d3b0a04 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756954 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://dawn.googlesource.com/dawn.git/+log/02233e019c4e..5ca21ed72084 2023-09-19 [email protected] [ir] Move `sampled_image` over to spirv builtins. 2023-09-18 [email protected] Roll vulkan-deps from dc9947ad4d2b to d96e99956ded (5 revisions) 2023-09-18 [email protected] Roll DirectX Shader Compiler from 549030f977a5 to e999412c4a5e (6 revisions) 2023-09-18 [email protected] generator_lib: Use forward slashes for CMake even on Windows 2023-09-18 [email protected] Resolve subgroupBroadcast If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn Bug: None Tbr: [email protected] Change-Id: Ieecb685c3fc4495d6fdd43ec3c6af6e94e452101 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756986 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/6e55411b61e1..1b17251d0e2c 2023-09-18 [email protected] Add Skia Perf configs for WebRTC instances. 2023-09-18 [email protected] Preserve log trace when there is only one error 2023-09-18 [email protected] Use skerr.Wrap more in httputils 2023-09-18 [email protected] [gold] search.go: Rename stageOneResults to digestWithTraceAndGrouping and stageTwoResults to digestAndClosestDiffs. 2023-09-18 [email protected] [gold] Update frontend. 2023-09-18 [email protected] [perf] Move tests/devices to end of Android-X notify template. 2023-09-18 [email protected] [perf] Don't zero out ParamSet in regression detection. 2023-09-18 [email protected] rename color variables to use material names 2023-09-18 [email protected] [gold] digest-details-sk: Don't crash when digest is outside of current tile. 2023-09-18 [email protected] Roll Skia Infra CIPD packages from 18fd0925a396 to 6e55411b61e1 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: If776e30e4d9fed10969e7219b908f5e85087b203 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757636 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://chromium.googlesource.com/angle/angle.git/+log/18f1b3b8e79d..91ef1f3cfd30 2023-09-19 [email protected] Move buffer suballocation callers to ContextVk 2023-09-19 [email protected] Vulkan: Flush pending image garbage more often 2023-09-19 [email protected] Vulkan: Flush pending suballoc garbage more often 2023-09-18 [email protected] Add ProgramOutput struct for ProgramExecutable::mOutputVariables 2023-09-18 [email protected] Don't pack gl_TessLevelInner/Outer 2023-09-18 [email protected] Vulkan: Fix buffer storage reuse bug when robustAccess is enabled 2023-09-18 [email protected] Add the missing multisample and rgb565-no-depth-no-stencil tests. 2023-09-18 [email protected] Remove forward-to-executable helpers from program 2023-09-18 [email protected] Vulkan: Disable VK_EXT_host_image_copy on Fuchsia 2023-09-18 [email protected] Call ReleaseThread() entry point from ThreadCleanupCallback 2023-09-18 [email protected] Fix "win-asan-test" random failures and timeouts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: [email protected] Test: Test: angle_end2end_tests --gtest_filter=EGLContextSharingTest.ThreadCleanupCallback* Test: Test: angle_end2end_tests --gtest_filter=EGLContextSharingTest.UnmakeFromCurrentOnThreadExit* Change-Id: I7cbfa4b4e8fbae73bb0ac8dfc37878b420097af4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757616 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Bug: b/295807418 Change-Id: I99fc592d168fd44ef69477990d454f9646cb2208 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757236 Commit-Queue: Dominik Röttsches <[email protected]> Commit-Queue: Dominik Röttsches <[email protected]> Reviewed-by: Dominik Röttsches <[email protected]>
This is setting up to add a PaintOption object as a correlate to PaintParams. Such an object would make it easier to pass around all the parameters needed to generate a precompilation key. Bug: 251493570 Change-Id: I5a5407ab5ebb031975cefe8419247a8074d8ccdd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756319 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
Manual roll requested by [email protected] https://chromium.googlesource.com/vulkan-deps.git/+log/293f55f6d3d0..640b7331b244 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected],[email protected] Change-Id: Ieff1bca69748f25e8a9af94fe1daef96f08e2396 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757620 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Manual roll requested by [email protected] https://dawn.googlesource.com/dawn.git/+log/5ca21ed72084..58dbcccc38b5 2023-09-19 [email protected] Roll vulkan-deps from d96e99956ded to 293f55f6d3d0 (3 revisions) 2023-09-19 [email protected] Roll DirectX Shader Compiler from e999412c4a5e to d949f78f69c0 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn Bug: None Tbr: [email protected],[email protected] Change-Id: I56ddfe8bce9eabc694ee3e065466a2ce45ac69ac Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756900 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
In this CL, a few test disables are migrated out of dm_flags to prove out the concept. More test disables can be migrated in a followup. Bug: b/40044139 Change-Id: I66a28c7e2d9ad6cbf8e8d99b9f6b318c600c6f96 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756496 Reviewed-by: Brian Osman <[email protected]> Auto-Submit: John Stiles <[email protected]> Commit-Queue: Brian Osman <[email protected]>
Bug: 251493570 Change-Id: Iaa72e6a569b71c73c1954dbc3beb30e2a167151a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/755945 Reviewed-by: Michael Ludwig <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
This will help us more cautiously roll out https://crrev.com/c/4864397 Bug: b/40045064 Change-Id: I772535ec638920ddcb792cb2875f9d48ec9dd2b5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757496 Reviewed-by: Brian Osman <[email protected]> Commit-Queue: Kevin Lubick <[email protected]>
Bug: b/40044139 Change-Id: I7a9e07ea04c32b1389f72bf284ff34b105979155 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756320 Auto-Submit: John Stiles <[email protected]> Reviewed-by: Brian Osman <[email protected]>
Bug: b/40044139 Change-Id: I1cb22a2f3db4c296b3dd37f2af53f553ca753222 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757517 Commit-Queue: John Stiles <[email protected]> Auto-Submit: John Stiles <[email protected]> Reviewed-by: Brian Osman <[email protected]>
This enforces IWYU on src/core/SkE* through SkH* and a few other files that broke as a result. Client CLs: - flutter/engine#46034 Change-Id: I4d5e0c44466ba94123aa3f6ce415bc3aa02fdbe8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757497 Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Brian Osman <[email protected]>
Manual roll requested by [email protected] https://chromium.googlesource.com/angle/angle.git/+log/91ef1f3cfd30..7cb117e0b06c 2023-09-19 [email protected] Roll vulkan-deps from dc9947ad4d2b to 640b7331b244 (9 revisions) 2023-09-19 [email protected] Cache isSeparable in the executable 2023-09-19 [email protected] Vulkan: Ignore VVL errors from GOOGLE extension 2023-09-19 [email protected] Roll Chromium from 0bbd400252a4 to 26ff6b8864ac (512 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: [email protected],[email protected] Change-Id: I3133604f197b771a357eb46848b5bf7c4e3e4415 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/756899 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Public changes- 3 new types are created: Slottable Text Property (mirrors TextProperty in SkottieProperty.h) VerticalTextAlign and ResizePolicy Change-Id: Ide8336ac635f452c2517063ee1bbf702f5eca6ed Reviewed-on: https://skia-review.googlesource.com/c/skia/+/753137 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Jorge Betancourt <[email protected]> Reviewed-by: Kevin Lubick <[email protected]>
In some cases we can simplify what is stored in Recordings if we know that they are played back in order. Bug: chromium:1479330 Change-Id: Iccd03daf359bad24ab76a33316b8a450cc909824 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757017 Reviewed-by: Michael Ludwig <[email protected]> Reviewed-by: Greg Daniel <[email protected]> Commit-Queue: Jim Van Verth <[email protected]>
The objective is to move SkShaper::MakeSkUnicodeBidiRunIterator into its own file. To land this requires setting everything up to build both with and without the new target, updating users to use the new target, then moving the code. Change-Id: I28091525677a9b31ee6dc60e5bb7a94d487132d8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/757817 Reviewed-by: Kevin Lubick <[email protected]> Commit-Queue: Kevin Lubick <[email protected]> Commit-Queue: Ben Wagner <[email protected]> Auto-Submit: Ben Wagner <[email protected]>
This reverts commit 7c31c55. Reason for revert: Issue with G3 and exec_tools Original change's description: > Add fontations gm to Bazel build of viewer > > Change-Id: Idb9d48e49ec7c501002bc0cb05e70cdda0c51e3c > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/760896 > Reviewed-by: Ben Wagner <[email protected]> > Commit-Queue: Kevin Lubick <[email protected]> Change-Id: Id737ef489abba2ce54e2b4fd502df91b2750aea0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761736 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Kevin Lubick <[email protected]>
I needed to add the explicit "-lpthread" link option due to GCC 10 (on the Debian docker image) being a bit older than GCC 13 on my desktop (the previous "test" mechanism). Rather than use the existing docker.py recipe, I made a new taskdriver for this to reduce use of the recipe system. I did have to update the Docker11 image due to needing a few more dependencies when downloading bazelisk and using it. I chose to put this in BazelTest because that already has a mechanism for specifying a custom taskdriver. Change-Id: I3662dd90cb125b5333ed798bbfaf5abbc7f5bfce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761376 Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Leandro Lovisolo <[email protected]>
…ion"" This reverts commit c41b771. Reason for revert: failing unit tests in android and flutter Original change's description: > Reland "[skif] Draw FilterResults directly for layer restoration" > > This reverts commit 33502f9. > > Reason for revert: staging for g3 has landed > > Original change's description: > > Revert "[skif] Draw FilterResults directly for layer restoration" > > > > This reverts commit 84b5116. > > > > Reason for revert: g3 also needs staging. > > > > Original change's description: > > > [skif] Draw FilterResults directly for layer restoration > > > > > > Many of the upfront optimization analysis is handled automatically in > > > applyColorFilter() and drawing with the blender. This means that when > > > we have a restore that floods the clip we don't force the input image > > > to flood as well, we can apply that at the very end during rendering. > > > > > > Additionally, any deferred effects like color filters and matrix > > > transforms from the final filters in the DAG can be applied when > > > drawing directly to the restore target device. Eventually when we get > > > to deferring the shader evaluation, this will further allow a filters > > > to avoid intermediate renderpasses. > > > > > > The overall logic is simpler now as well, and the empty input filter > > > case can reuse internalDrawDeviceWithFilter() now too. > > > > > > Bug: b/40040587 > > > Bug: b/40042615 > > > Change-Id: I12c452918f2229abdc55b4df4a18a1ccc2abf3aa > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759117 > > > Reviewed-by: Brian Osman <[email protected]> > > > Commit-Queue: Michael Ludwig <[email protected]> > > > > Bug: b/40040587 > > Bug: b/40042615 > > Change-Id: Ibd02b91adffab199b73e865c027cfee2726445ad > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761276 > > Commit-Queue: Rubber Stamper <[email protected]> > > Auto-Submit: Michael Ludwig <[email protected]> > > Bot-Commit: Rubber Stamper <[email protected]> > > Bug: b/40040587 > Bug: b/40042615 > Change-Id: I316813e2f7268f75be4c5afa5b80deb6627c1141 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761380 > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Michael Ludwig <[email protected]> Bug: b/40040587 Bug: b/40042615 Change-Id: I00a828e597f20574113232b917668401eae3ff9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761418 Auto-Submit: Michael Ludwig <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/8ac5d8e1a9fe..285e37076672 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/576f3286e10ca0c98fc481787b27e229bd61ac8f..3a19c1973f0e4732b8f3746593aee2ac425ecb78 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/57a5103a04ed5ce24463d6794dd6f96ceba126b1..fd80ac354313d190eeaa33180ededa4de8c474b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I1a07910f26bafd754420337f692f44231d53a545 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761475 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/285e37076672..1e918eeb6193 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/fd80ac354313d190eeaa33180ededa4de8c474b4..2169a0849e3df4e2133b728dec67d3b16bd30263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I17a4c9b5deb790405497da3a43b1e02c5e528eff Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761836 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/c8eb90e92f62..a17b968c91ef 2023-09-29 [email protected] Roll Skia Infra CIPD packages from d0c5366041fc to c8eb90e92f62 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: I16334e6a874672229060cf107ed85d2fcb39dc45 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761319 Bot-Commit: skia-autoroll <[email protected]> Commit-Queue: skia-autoroll <[email protected]>
https://skia.googlesource.com/buildbot.git/+log/a17b968c91ef..f16639bc3b92 2023-10-02 [email protected] Roll Skia Infra CIPD packages from c8eb90e92f62 to a17b968c91ef (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/sk-tool-skia Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I5d72841ce3459a187fff33964ad87d3c4d4b1d24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761840 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
https://chromium.googlesource.com/vulkan-deps.git/+log/1e918eeb6193..1e40b8e966f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: [email protected] Change-Id: I123c3239acdf51b45c0832eb345c9517f0572c82 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761999 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Add a locale text property field, and plumb all the way to SkShaper. Bug: b/263268721 Change-Id: I55fe5436da24c8fca0f81e5d238d0994cd24fcf1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761237 Commit-Queue: Florin Malita <[email protected]> Reviewed-by: Ben Wagner <[email protected]>
The old 5.3.2 had a glitch that prevent tools from working correctly with our cc_binary_with_flags (which is hopefully going away soon). This updates both. go/genrule-exec-tools-cleanup-lsc Change-Id: I808e3aa134f6c9c6755306c63be07ca33b58de78 Bug: b/256864786 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/729416 Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Ben Wagner <[email protected]>
Bug: b/297220808 Change-Id: Ia9dc77675473f405b379eb7db30a64703e2fa5e5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/759937 Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Herb Derby <[email protected]>
Previously this logic was embedded in `emitRootFragProc`. Bug: b/40045302 Change-Id: Ib4d8ac0ba540aeee3a90a6eb9f23eec7c4137826 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761717 Commit-Queue: John Stiles <[email protected]> Auto-Submit: John Stiles <[email protected]> Reviewed-by: James Godfrey-Kittle <[email protected]>
Change-Id: Id3562e32d7029cafea5c37853a7a91745eb36342 Bug: b/40044159 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761716 Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Robert Phillips <[email protected]>
Change-Id: I26223ee221fc703b8b00b0ba7173cce3011d3b45 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762076 Commit-Queue: Jorge Betancourt <[email protected]> Auto-Submit: Florin Malita <[email protected]> Reviewed-by: Jorge Betancourt <[email protected]>
These are not very useful yet, since the only allowed FPs are null. Bug: b/40045302 Change-Id: I08a1b58cb5b0da6849b411dcd61c5a9ea4eb9f6e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/761656 Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Robert Phillips <[email protected]>
Change-Id: I0bce51db50bcb648f89eba8997ece132d2650b10 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762143 Commit-Queue: Heather Miller <[email protected]> Auto-Submit: Rakshit Sharma <[email protected]> Reviewed-by: Heather Miller <[email protected]>
Change-Id: I3620870429f56b9406cf5e89e15a21981b8edd3a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762278 Reviewed-by: Heather Miller <[email protected]> Reviewed-by: Kevin Lubick <[email protected]>
The low-res blurred image was rendered into the rounded-out coords, and any decal-tiling should occur beyond their boundaries. By using the original scaled coords as the subset boundary, we'd introduce transparency at the edge when re-expanding. Previously this was never visible because of quirks in how SkBlurImageFilter requested its output (always padded with the blur radius, even if it were to then be cropped). While the changes to the subsetting logic accounted for 90% of the visible seams when testing in chrome (and all the visible seams when running in viewer), it was also necessary for the downscaled blur to write one extra pixel of padding that could be sampled from when doing the re-expand. Bug: chromium:1500021 Change-Id: I18c147270db7b42568f4e7034b13c2dc4ab19e4a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/775517 Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Michael Ludwig <[email protected]> (cherry picked from commit e585bb6) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/776156 Commit-Queue: John Stiles <[email protected]> Auto-Submit: Michael Ludwig <[email protected]> Reviewed-by: John Stiles <[email protected]>
Bug: chromium:1505053 Change-Id: I42f2ff872bbf054686ec7af0cc85ff63055fcfbf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/782936 Commit-Queue: Michael Ludwig <[email protected]> Reviewed-by: Michael Ludwig <[email protected]> Auto-Submit: John Stiles <[email protected]> (cherry picked from commit 6169a1f) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/783296 Reviewed-by: John Stiles <[email protected]> Commit-Queue: Brian Osman <[email protected]> Auto-Submit: Brian Osman <[email protected]> Commit-Queue: John Stiles <[email protected]>
The Flutter roll was failing due to -Wsign-compare. Bug: chromium:1505053 Change-Id: Id12876f6f97682466f19b56cfa562366380f27cb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/783036 Auto-Submit: John Stiles <[email protected]> Commit-Queue: Brian Osman <[email protected]> Reviewed-by: Brian Osman <[email protected]> (cherry picked from commit 0eea0b2) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/782579 Commit-Queue: John Stiles <[email protected]> Reviewed-by: John Stiles <[email protected]> Auto-Submit: Brian Osman <[email protected]>
Change-Id: Iba0a5f181d32c26b5cf199bcaa03094308e81804 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/815462 Reviewed-by: Heather Miller <[email protected]>
…kia-119 # Conflicts: # DEPS # RELEASE_NOTES.md # infra/bots/jobs.json # src/gpu/ganesh/gl/webgl/GrGLMakeNativeInterface_webgl.cpp
# Conflicts: # DEPS
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updates skia engine to milestone 119.
API Changes
sk_time_datetime_tis nowsk_document_pdf_datetime_tRGBA_10X6_SK_COLORTYPEBehavioral Changes
None.
Required SkiaSharp PR
Requires mono/SkiaSharp#3062
PR Checklist
skiasharpat time of PR