Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet 7 migration #335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dotnet 7 migration #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47a996f
Dotnet 7 migration
Aug 27, 2023
2aebe25
Update Directory.Build.props
xaviergxf Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
<RepositoryUrl>https://github.com/mono/taglib-sharp</RepositoryUrl>
<RepositoryType>git</RepositoryType>

<!-- Make sure to update Directory.Build.targets too! -->
<ExeTargetFrameworks>net6.0;net472</ExeTargetFrameworks>
<LibTargetFrameworks>net6.0;netstandard2.0</LibTargetFrameworks>
<ExeTargetFrameworks>net7.0;net472</ExeTargetFrameworks>
<LibTargetFrameworks>net7.0;netstandard2.0</LibTargetFrameworks>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xaviergxf Thanks for the PR. Could I have you leave the net6.0 and add net8.0 instead. net8.0 is an LTS version and was just barely released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it on my side but there are now problems regarding deprecation of Formatter-based serialization. I don't understand why this is used...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh fun :) ok, I'll try and take a peek at this too.

<LangVersion>latest</LangVersion>
</PropertyGroup>

Expand Down