fix(ui): focus Wine window when opening Steam while already running - #147
Open
amir-rezaei wants to merge 1 commit into
Open
fix(ui): focus Wine window when opening Steam while already running#147amir-rezaei wants to merge 1 commit into
amir-rezaei wants to merge 1 commit into
Conversation
Collaborator
|
@amir-rezaei or anyone send a video proving the fix if you can, because from what I think, steam get exited when closing a game and focusing the wine window will do nothing as steam is exited, and due to the minority of the issue, I'll not diagnosis the cause concretely yet |
realmaitreal
added
Low priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #106 by ensuring that clicking "Open Steam" in
BackendClient.swiftfocuses the Steam Wine window even when Steam is already running in the background.Details
launch_steamreturnedalready_running: true,launchSteamignored the response without raising or focusing the existing Steam window.focusWineWindow()upon receiving a successful response fromlaunch_steamso the running Steam client is brought to the foreground.