perf(epic): back off idle download polling when no downloads are active - #149
Open
amir-rezaei wants to merge 1 commit into
Open
perf(epic): back off idle download polling when no downloads are active#149amir-rezaei wants to merge 1 commit into
amir-rezaei wants to merge 1 commit into
Conversation
realmaitreal
left a comment
realmaitreal
left a comment
Collaborator
There was a problem hiding this comment.
That's making it better, but it would be even better we replace polling with an event from legendary directly
realmaitreal
added
enhancement
Owner
|
@amir-rezaei whats your discord? |
Author
|
Thanks @realmaitreal and @mont127! Good suggestion on integrating event notifications directly from Legendary when active downloads change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #125 by backing off background download polling in
EpicLandingView.swiftwhen no downloads are active.Details
startGamesPollingcontinuously polledlegendary_all_downloadsevery 3 seconds regardless of whether any download task was in progress.backend.epicDownloadsis empty (and maintains 3 seconds during active downloads), reducing CPU and IPC log churn.