Skip to content

fix(winetricks): warn on d3d DirectX DLL override winetricks verbs - #160

Open
amir-rezaei wants to merge 1 commit into
mont127:mainfrom
amir-rezaei:fix/winetricks-risk-d3d-overrides-warning
Open

fix(winetricks): warn on d3d DirectX DLL override winetricks verbs#160
amir-rezaei wants to merge 1 commit into
mont127:mainfrom
amir-rezaei:fix/winetricks-risk-d3d-overrides-warning

Conversation

@amir-rezaei

Copy link
Copy Markdown

Description

This PR updates WinetricksRisk.warning(for:) in Sources/WinetricksCatalog.swift.

Details

  • Adds prefix check for d3d DirectX DLL override verbs (e.g. d3dcompiler, d3dx9, d3d11) to warn users before installing verbs that overwrite graphics rendering DLLs.

@realmaitreal realmaitreal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added v.hasPrefix("d3d") branch is broader than the rest of this function intends. The file's own doc comment is explicit that these prefixes are "read out of the bundled winetricks script itself, not guessd" and deliberately scoped to verbs that call helper_dxvk ... "dxgi,d3d8,d3d9,d3d10core,d3d11" (the dxvk*/galliumnine*/vkd3d families).

Plain d3d-prefixed winetricks verbs — d3dcompiler_43/_46/_47, d3dx9, d3dx10, d3dx11_43, d3drm — are common, safe DLL installs that many games require and that don't touch the d3d11/dxgi/d3d10core override set at all. With this change they'll now trip the same "Steam or your games may stop rendering" warning as an actual dxvk override, which is a false positive on some very frequently-installed verbs and undermines the "warn only when it's actually true" design documented right above this function.

Suggest narrowing this to the verbs that actually route through helper_dxvk (or enumerate the specific DLL-override verb names) rather than a bare d3d prefix.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants