fix(ui): guard games.isEmpty in ConsoleModeView.move - #170
Open
amir-rezaei wants to merge 1 commit into
Open
Conversation
realmaitreal
approved these changes
Jul 28, 2026
realmaitreal
left a comment
realmaitreal
left a comment
Collaborator
There was a problem hiding this comment.
Straightforward guard against indexing into an empty games array before selected + delta is computed. Same class of "empty collection" concern as #158 was trying to address, but correctly implemented here. No issues.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
ConsoleModeView.moveinSources/ConsoleModeView.swift.Details
guard !games.isEmptycheck to prevent invalid index access when navigating in Big Picture console mode while a bottle has no reachable games.