Skip to content

Update Git section of the Peer reveiw checklist #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Git section of the Peer reveiw checklist #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions general/development/process/peer-review/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,11 @@ Ensure that:
- The commit matches the [Coding style](../../policies/codingstyle/index.md#git-commits)
- The Git history is clean and the work has been rebased to logical commits; and
- The original author of the work provided as a patch has been given credit within the commit (as author of in the commit message if changes were made).
- Git branches have been provided for all the right Moodle branches. The [supported branches list|https://moodledev.io/general/releases#version-support] will help you decide:
- For improvements or new features, this means a branch based on `main` only.
- For normal bug fixes, this the `main` branch and all the 'Current stable' branches (that are affected by the bug).
- For security bugs, this is `main` and all the 'Current stable' and 'Current security' branches (but note the [special process for handling security fixes|https://moodledev.io/general/development/process#security-issues]).
- For improvements or new features in the Behat on PHPunit integration, this should be done on `main` and all the 'Current stable' and 'Current security' branches, providing the backporting is not too difficult.

See also the [Commit cheat sheet](https://docs.moodle.org/dev/Commit_cheat_sheet) for further guidance.

Expand Down