Refactor iOS Wake-on-LAN to be more correct and less of a shotgun #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch simplifies the WOL logic, and now loops through all active IPv4 interfaces and sends 1 magic packet to the broadcast address for each interface's subnet. Effectively this amounts to just one packet to the wifi interface's broadcast. All the rest of the packets, to high UDP ports, unicast IPv4 and IPv6 addresses, 255.255.255.255, were not correct, even if they might sometimes wake a recently-awake PC that could still receive unicast packets by dumb luck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the WOL logic, and now loops through all active IPv4 interfaces and sends 1 magic packet to the broadcast address for each interface's subnet. Effectively this amounts to just one packet to the wifi interface's broadcast.
All the rest of the packets, to high UDP ports, unicast IPv4 and IPv6 addresses, 255.255.255.255, were not correct, even if they might sometimes wake a recently-awake PC that could still receive unicast packets by dumb luck.