-
Notifications
You must be signed in to change notification settings - Fork 29
feat(fdc3) - Add initial FDC3 .NET Client package, refactored project names to collide with assembly names, added native app handling to ModuleLoader, HostManifestMapper #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10a5548
to
a840ba2
Compare
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{9E52D00C-AABB-4579-8724-6CC7049F021E}" | ||
EndProject | ||
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MorganStanley.ComposeUI.AppDirectory.Tests", "test\MorganStanley.ComposeUI.AppDirectory.Tests\MorganStanley.ComposeUI.AppDirectory.Tests.csproj", "{EAA7B5A8-FD08-4E2F-809B-6CBD489714C1}" | ||
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MorganStanley.ComposeUI.Fdc3.AppDirectory.Tests", "test\MorganStanley.ComposeUI.Fdc3.AppDirectory.Tests\MorganStanley.ComposeUI.Fdc3.AppDirectory.Tests.csproj", "{EAA7B5A8-FD08-4E2F-809B-6CBD489714C1}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affect nuget package names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No NuGet package names are derived from the Assembly names defined in the csproj files like:
https://github.com/morganstanley/ComposeUI/blob/main/src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/MorganStanley.ComposeUI.DesktopAgent.csproj#L4
src/fdc3/dotnet/DesktopAgent.Client/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client.sln
Show resolved
Hide resolved
public static IServiceCollection AddFdc3DesktopAgentClient( | ||
this IServiceCollection serviceCollection) | ||
{ | ||
serviceCollection.AddTransient<IDesktopAgent, DesktopAgentClient>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be singleton? Adding as transient would mean creating new clients in fire and forget style each time it's requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this should be singleton
5208553
to
a813eff
Compare
… names to collide with assembly names, Added native app handling to ModuleLoader, HostManifestMapper
a813eff
to
ee01b9b
Compare
91e3a1a
to
ed5709c
Compare
Changes: