Skip to content

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Aug 28, 2025

Changes:

  • Renamed projects to be consistent with the given assembly names (updated folders some namespaces)
  • Created MorganStanley.ComposeUI.Fdc3.DesktopAgent.Shared to contain the common Request/Response types and classes that should be used both in FDC3 client and backend packages
  • Created MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client package to implement the client behavior for sending the requests from native applications
  • Modified ModuleLoader to handle Native manifest properties
  • Modified ModuleLoader AppDirectory reader to be able to read native app details
  • Modified sample HostManifest implementation to handle reading the native app properties in case of ComposeUI
  • NEW COMMIT: added GetInfo implementation
image

@lilla28 lilla28 requested a review from a team as a code owner August 28, 2025 13:30
@lilla28 lilla28 force-pushed the feat/fdc3-client-net branch 3 times, most recently from 10a5548 to a840ba2 Compare August 28, 2025 15:21
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 47.88136% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.1%. Comparing base (5419eb4) to head (d43ac1c).

Files with missing lines Patch % Lines
...tnet/src/Shell/Fdc3/ComposeUIHostManifestMapper.cs 27.0% 33 Missing and 2 partials ⚠️
...y.ComposeUI.Fdc3.AppDirectory/Fdc3ModuleCatalog.cs 0.0% 26 Missing ⚠️
...pAgent.Client/Infrastructure/DesktopAgentClient.cs 68.3% 16 Missing and 3 partials ⚠️
...ey.ComposeUI.Fdc3.DesktopAgent/Fdc3DesktopAgent.cs 18.1% 16 Missing and 2 partials ⚠️
...y.ComposeUI.Fdc3.DesktopAgent/Fdc3StartupAction.cs 56.6% 9 Missing and 4 partials ⚠️
.../src/Shell/Messaging/MessageRouterStartupAction.cs 0.0% 8 Missing ⚠️
...mposeUI.ModuleLoader/Runners/NativeModuleRunner.cs 78.5% 3 Missing ⚠️
....Fdc3.DesktopAgent/Extensions/Fdc3AppExtensions.cs 0.0% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (47.8%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1076     +/-   ##
=======================================
- Coverage   66.6%   66.1%   -0.5%     
=======================================
  Files        338     342      +4     
  Lines      10086   10255    +169     
  Branches    1122    1247    +125     
=======================================
+ Hits        6723    6786     +63     
- Misses      3090    3185     +95     
- Partials     273     284     +11     
Files with missing lines Coverage Δ
...tanley.ComposeUI.Fdc3.AppDirectory/AppDirectory.cs 85.3% <ø> (ø)
...ComposeUI.Fdc3.AppDirectory/AppDirectoryOptions.cs 100.0% <ø> (ø)
...jection/ServiceCollectionAppDirectoryExtensions.cs 100.0% <ø> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <100.0%> (ø)
...gent.Shared/Contracts/AddContextListenerRequest.cs 100.0% <ø> (ø)
...ent.Shared/Contracts/AddContextListenerResponse.cs 100.0% <ø> (ø)
...pAgent.Shared/Contracts/CreateAppChannelRequest.cs 100.0% <ø> (ø)
...Agent.Shared/Contracts/CreateAppChannelResponse.cs 100.0% <ø> (ø)
...nt.Shared/Contracts/CreatePrivateChannelRequest.cs 0.0% <ø> (ø)
...t.Shared/Contracts/CreatePrivateChannelResponse.cs 0.0% <ø> (ø)
... and 102 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{9E52D00C-AABB-4579-8724-6CC7049F021E}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MorganStanley.ComposeUI.AppDirectory.Tests", "test\MorganStanley.ComposeUI.AppDirectory.Tests\MorganStanley.ComposeUI.AppDirectory.Tests.csproj", "{EAA7B5A8-FD08-4E2F-809B-6CBD489714C1}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "MorganStanley.ComposeUI.Fdc3.AppDirectory.Tests", "test\MorganStanley.ComposeUI.Fdc3.AppDirectory.Tests\MorganStanley.ComposeUI.Fdc3.AppDirectory.Tests.csproj", "{EAA7B5A8-FD08-4E2F-809B-6CBD489714C1}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect nuget package names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public static IServiceCollection AddFdc3DesktopAgentClient(
this IServiceCollection serviceCollection)
{
serviceCollection.AddTransient<IDesktopAgent, DesktopAgentClient>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be singleton? Adding as transient would mean creating new clients in fire and forget style each time it's requested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this should be singleton

@lilla28 lilla28 force-pushed the feat/fdc3-client-net branch 2 times, most recently from 5208553 to a813eff Compare September 22, 2025 21:34
@lilla28 lilla28 force-pushed the feat/fdc3-client-net branch from a813eff to ee01b9b Compare September 22, 2025 21:36
@lilla28 lilla28 force-pushed the feat/fdc3-client-net branch from 91e3a1a to ed5709c Compare September 22, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants