Skip to content

Conversation

bigint
Copy link

@bigint bigint commented Aug 26, 2025

  • Update customizer to use generic <T> with proper string | number | symbol key type
  • Return undefined explicitly for compatibility with lodash mergeWith
  • Ensures stricter type-safety when merging custom addresses, deployments, and unwrapped tokens

@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 17:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves type safety in the registerCustomAddresses function by replacing the loose any typing in the customizer function with proper generic types. The changes ensure stricter type checking when merging custom addresses, deployments, and unwrapped tokens.

  • Replace any types with generic <T> type parameter for better type safety
  • Add explicit void return type for lodash mergeWith compatibility
  • Update parameter types to use T | undefined instead of any

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of this type is not much but lgtm

@bigint bigint closed this by deleting the head repository Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants