MOSIP-29593 Record status comment for failed status #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwa-vyom
requested changes
Oct 5, 2023
Member
vishwa-vyom
left a comment
vishwa-vyom
left a comment
There was a problem hiding this comment.
Code changes are good, since we are connecting to 1.1.5.5, it works but someone running 1.1.4.4, it will cause consistency issue, lets discuss on this to Rounak and Loga once.
| private LocalDateTime deletedDateTime; | ||
|
|
||
| @Column(name = "status_comment") | ||
| private String statusComment; |
Member
There was a problem hiding this comment.
As per the default db schema of 1.1.4.4 we might not have this field, this change will cause consistence issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.