Skip to content

[MOSIP-43640] Update keycloak init#194

Merged
Prafulrakhade merged 3 commits intorelease-1.3.xfrom
Prafulrakhade-patch-1
Dec 4, 2025
Merged

[MOSIP-43640] Update keycloak init#194
Prafulrakhade merged 3 commits intorelease-1.3.xfrom
Prafulrakhade-patch-1

Conversation

@Prafulrakhade
Copy link
Member

@Prafulrakhade Prafulrakhade commented Dec 4, 2025

Summary by CodeRabbit

  • Chores
    • Updated PostgreSQL image configuration method in the deployment process to use current standards and best practices
    • Enhanced Keycloak deployment initialization script with interactive prompts for flexible service name configuration and automatic setup of external and internal network host settings to improve deployment flexibility and provide better customization capabilities for different deployment scenarios

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Walkthrough

These changes update Keycloak deployment configuration by migrating PostgreSQL image references to newer Helm chart keys and introducing new interactive inputs for Keycloak service naming and host configuration during initialization.

Changes

Cohort / File(s) Summary
PostgreSQL image key migration
deploy/install.sh
Updates Helm install command to use newer postgresql.image.repository and postgresql.image.tag keys instead of deprecated postgresql.primary.image.repository and postgresql.primary.image.tag keys.
Keycloak initialization configuration
deploy/keycloak_init.sh
Introduces interactive input for KEYCLOAK_SERVICE_NAME with default value "keycloak"; adds two new Helm set-values (keycloakExternalHost and keycloakInternalHost) to keycloak-init release configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

  • Both changes are configuration updates to shell scripts without complex control flow logic
  • PostgreSQL key migration is a straightforward parameter substitution
  • New keycloak-init inputs follow existing patterns and are self-contained additions
  • Primary review focus: verify correct Helm parameter names and that new host configuration values are properly constructed

Possibly related PRs

Suggested reviewers

  • ckm007

Poem

🐰 A rabbit hops through deploy scripts bright,
PostgreSQL keys now shimmer right,
New service names and hosts take flight,
Config grows taller, oh what a sight!
Keycloak initialization feels so right! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title is vague and generic, using only 'Update keycloak init' which provides minimal insight into the actual changes made to the deployment process. Consider a more descriptive title that captures the main changes, such as 'Update PostgreSQL image keys and add Keycloak service configuration' or 'Migrate PostgreSQL Helm values and configure Keycloak hosts'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Prafulrakhade-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Copy link
Contributor

@Mohanraj209 Mohanraj209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8db8684 and b3ed935.

📒 Files selected for processing (2)
  • deploy/install.sh (1 hunks)
  • deploy/keycloak_init.sh (2 hunks)
🔇 Additional comments (1)
deploy/keycloak_init.sh (1)

73-74: keycloakExternalHost and keycloakInternalHost are valid Helm parameters in keycloak-init 1.3.0-develop.

These parameters are properly defined in the chart's values.yaml (lines 743-744) and are actively used in the configmap template to generate ConfigMap entries (keycloak-internal-host, keycloak-internal-url, keycloak-external-host, keycloak-external-url, keycloak-internal-service-url). The ConfigMap is consumed by the keycloak-init job to configure internal and external Keycloak host connectivity.

@Prafulrakhade Prafulrakhade merged commit 62af9a9 into release-1.3.x Dec 4, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants