Skip to content

Conversation

@ckm007
Copy link
Member

@ckm007 ckm007 commented Dec 23, 2025

Automated PR for release.

Summary by CodeRabbit

  • Chores
    • Updated Helm chart version to stable 1.3.0.
    • Updated container image repositories and tags to the mosipid images (tag 1.3.0).
    • Updated deployment scripts and Helm addon/version references used during install/upgrade.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

Chart and deployment references for keycloak-init were updated: chart version moved from 1.3.0-develop → 1.3.0 and container image repository/tag references changed from mosipqa/...:1.3.x to mosipid/...:1.3.0 across Helm values and deployment scripts.

Changes

Cohort / File(s) Summary
Helm Chart Metadata
helm/keycloak-init/Chart.yaml
Chart version changed from 1.3.0-develop1.3.0
Helm values / Container image
helm/keycloak-init/values.yaml
Image repository changed mosipqa/keycloak-initmosipid/keycloak-init; image tag 1.3.x1.3.0; minor formatting/comment adjustments
Deployment scripts
deploy/import-init.sh, deploy/install.sh, deploy/keycloak_init.sh, deploy/upgrade-init.sh
CHART_VERSION/ISTIO_ADDONS_CHART_VERSION and image repository/tag constants updated (versions and registry); no control-flow or logic changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Hop-hop—version set to go, from develop to 1.3.0,
Registry moved with a nimble bound, new tag snug and sound,
Charts aligned, scripts agree, deploys will now run free,
I nibble carrots, give a cheer—Keycloak's release is here! 🎉

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title references version 1.2.1.0 but the changeset updates chart/image versions to 1.3.0, creating a version mismatch between the stated release version and actual changes. Correct the PR title to reflect the actual release version being shipped (1.3.0) or verify that the version updates in the changeset match the intended release (1.2.1.0).
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch releas-branch

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e03cc9e and 166c957.

📒 Files selected for processing (4)
  • deploy/import-init.sh
  • deploy/install.sh
  • deploy/keycloak_init.sh
  • deploy/upgrade-init.sh
✅ Files skipped from review due to trivial changes (1)
  • deploy/keycloak_init.sh
🔇 Additional comments (4)
deploy/upgrade-init.sh (1)

12-12: Chart version update is consistent.

The chart version update to 1.3.0 matches the change in deploy/import-init.sh, ensuring consistency across deployment scripts.

deploy/import-init.sh (1)

12-12: Verify Helm chart version 1.3.0 availability before deployment.

The mosip/keycloak-init Helm chart version must be confirmed as available in the repository. Add this verification to the deployment checklist or CI/CD pipeline to ensure the chart can be pulled during deployment.

deploy/install.sh (2)

128-129: Docker image availability requires verification before deployment.

The deployment script references mosipid/mosip-artemis-keycloak:1.3.0. Verify that this image exists and is accessible in the mosipid Docker registry before deployment. Check Docker Hub or your internal registry to confirm the image is available.

Likely an incorrect or invalid review comment.


10-10: Verify istio-addons chart version availability.

The istio-addons chart version has been updated from 0.0.1-develop to 1.0.0 for the GA release. Please verify that version 1.0.0 exists in the mosip Helm repository.

Run the following script to verify the chart version:

#!/bin/bash
# Verify that istio-addons chart version 1.0.0 exists in mosip Helm repository

helm repo add mosip https://mosip.github.io/mosip-helm 2>/dev/null || true
helm repo update mosip

echo "Searching for istio-addons chart version 1.0.0..."
helm search repo mosip/istio-addons --version 1.0.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
helm/keycloak-init/values.yaml (1)

228-228: Consider using boolean values instead of quoted strings for YAML attributes.

The static analysis correctly identifies that YAML attributes use string values "true" and "false" instead of boolean true and false. While functional, using proper boolean values is more idiomatic and reduces potential parsing ambiguity.

🔎 Proposed fix to use boolean values
-          attributes: {display.on.consent.screen: "false", include.in.token.scope: "true"}
+          attributes: {display.on.consent.screen: false, include.in.token.scope: true}

Apply this pattern to all affected lines (228, 233, 238, 243, 253, 258, 263). Line 248 uses "true" for display.on.consent.screen, which should also be true.

Note: Verify that Keycloak correctly interprets boolean values before applying this change, as some systems may expect string representations.

Based on static analysis hints.

Also applies to: 233-233, 238-238, 243-243, 248-248, 253-253, 258-258, 263-263

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25eb9f4 and e03cc9e.

📒 Files selected for processing (2)
  • helm/keycloak-init/Chart.yaml
  • helm/keycloak-init/values.yaml
🧰 Additional context used
🪛 GitHub Check: chart-lint-publish / chart-lint-publish
helm/keycloak-init/values.yaml

[warning] 262-262:
262:37 [truthy] truthy value should be one of [false, true]


[warning] 257-257:
257:37 [truthy] truthy value should be one of [false, true]


[warning] 252-252:
252:37 [truthy] truthy value should be one of [false, true]


[warning] 247-247:
247:37 [truthy] truthy value should be one of [false, true]


[warning] 242-242:
242:37 [truthy] truthy value should be one of [false, true]


[warning] 237-237:
237:37 [truthy] truthy value should be one of [false, true]


[warning] 232-232:
232:37 [truthy] truthy value should be one of [false, true]

🔇 Additional comments (1)
helm/keycloak-init/values.yaml (1)

7-10: Image repository and tag changes look correct for GA release.

The change from mosipqa/keycloak-init to mosipid/keycloak-init and the tag pinning from 1.3.x to 1.3.0 are appropriate for a production GA release. Ensure the production image has been built and pushed to the registry.

This was already covered by the verification script in Chart.yaml review.

@ckm007 ckm007 merged commit 59a474d into release-1.3.x Dec 23, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants