-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build index problem in reinstallation #16
base: dev
Are you sure you want to change the base?
Conversation
zipcodetw.builder.build() | ||
try: | ||
zipcodetw.builder.build() | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should catch only sqlite's exception .
A better approach is to fix the code inside .builder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I also encounter this when installing for the first time in rpmbuild, because packaging splits setup.py build
and setup.py install
into two steps. Thanks for the fix.
https://build.opensuse.org/package/show/home:jayvdb:py-new/python-zipcodetw
Hmmm ... I can install after uninstall or |
Sounds like you were using pip and had an environment which doesnt replicate the problem. Try using Nothing has exception handling if the tables already exist. |
Could you kindly confirm the issue is same as #31? |
It is unrelated to #31 |
As the error code while doing reinstallation(remove and install again):
The code in setup.py: zipcodetw.builder.build() will cause the error above which need to [try expect] to let reinstallation can be successfully, thxs ~