Add weekly riding input, inline feedback, and weekly-based savings calculations#1
Open
moustyb wants to merge 1 commit into
Open
Add weekly riding input, inline feedback, and weekly-based savings calculations#1moustyb wants to merge 1 commit into
moustyb wants to merge 1 commit into
Conversation
Deploying co2-calculator with
|
| Latest commit: |
1b861d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40bee685.co2-calculator-atb.pages.dev |
| Branch Preview URL: | https://codex-upgrade-the-code.co2-calculator-atb.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
alert()s with an inline, accessible status message to communicate validation and success.Description
Days biked per weeknumeric input and an accessible inline message element (#formMessage) toindex.html.script.jsto add constants forDAYS_PER_WEEK,WEEKS_PER_YEAR, andMONTHS_PER_YEAR, to validate the new input, and to replace alert-based validation withsetMessage()which updates the inline status element.formatNumber()for locale-friendly output..form-messagesuccess/error styles tostyle.cssfor the inline status feedback.Testing
node --check script.js, which completed successfully.python3 -m http.server 4173and ran an automated Playwright script that fills the form, submits a sample calculation, and captured a screenshot to verify UI and result rendering, which succeeded.Codex Task