lsp server: fix response sending order #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, "timeout" was being shown before "unknown" results in the vscode extension. Now, the "unknown" results are sent before the server responds to the verify request with "timeout" or "interrupt"
|
Could you explain why that's correct? The code looks a bit weird to me. Why are we doing two Could you maybe just refactor that code to have just one match statements that handles everything explicitly? |
Philipp15b
reviewed
Feb 6, 2025
src/servers/lsp.rs
Outdated
| server.lock().unwrap().add_diagnostic(diagnostic)?; | ||
| } | ||
| VerifyError::Interrupted | VerifyError::LimitError(_) => { | ||
| // If the verification is interrupted or a limit is reached before the verification starts, no verification statuses are published yet. |
There was a problem hiding this comment.
Why handle that case here? Why don't we just immediately publish_verify_statuses() after registering them?
Also, isn't this case about publishing those that are now timeouts, not Todo anymore?
…e todo-to-timeout transformation to lsp server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a timeout occurs the "timeout" message becomes visible before the remaining procs are marked with "unknown" results. This PR fixes this bug by reordering the response order.