Repository navigation
fix(docs): ExtensionSettings improvements, fix 3rdparty description - #350
Merged
Merged
Conversation
bsmth
changed the title
Collaborator
Author
|
Going to merge for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
ExtensionSettingspolicy needs a larger refresh.3rdpartydescription here needs to be fixed.Motivation:
Docs had wrong info introduced at some point.
For ExtensionSettings, we need better info to help guide admins.
For reviewers: I've spent a lot of time reading through the changes and iterating over this, and I'm fairly confident in the changes here, still expert eyes are very welcome.
Related issues and pull requests: