Forward Felt new window requests via IPC. #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the URL opening IPC with a flag indicating where to open things.
gcp
force-pushed
the
right-click-actions
branch
from
0beecbc to
45fa1e2
Compare
Because we changed the message format.
1rneh
requested changes
Jan 5, 2026
Contributor
1rneh
left a comment
1rneh
left a comment
There was a problem hiding this comment.
Thanks, overall the changes on the js side look good!
Two things I noticed:
- Most of these changes still need some
#ifdef MOZ_ENTERPRISE-ing. - The code that handles external links and requests new windows is very distributed. I think a new module that centralizes all that logic would help.
| export let gFeltPendingURLs = []; | ||
| const FELT_OPEN_DISPOSITION_DEFAULT = 0; | ||
| const FELT_OPEN_DISPOSITION_NEW_WINDOW = 1; | ||
| const FELT_OPEN_DISPOSITION_NEW_PRIVATE_WINDOW = 2; |
Contributor
There was a problem hiding this comment.
Let's export these flags here and import them wherever needed (e.g. in browser/base/content/nonbrowser-mac.js and browser/extensions/felt/api.js). Maybe also wrap them in an enum?
export const FELT_OPEN_WINDOW_DISPOSITION = {
DEFAULT : 0,
NEW_WINDOW : 1,
NEW_PRIVATE_WINDOW : 2,
}
| // Make sure that when FeltUI is requested, we do not try to open another | ||
| // window. Instead, forward any URLs to be opened in the real Firefox. | ||
| if (Services.felt.isFeltUI()) { | ||
| if (isFeltUI) { |
Contributor
There was a problem hiding this comment.
Could we delcare isFeltUI closer to its usage? Or actually, since it's only used once, we could generally drop the variable and call Services.felt.isFeltUI(); directly.
| ); | ||
| queueURL(payload); | ||
| } catch (err) { | ||
| gFeltPendingURLs.push(payload); |
Contributor
There was a problem hiding this comment.
Maybe also leave a log message console.warn(`Retrying to queue url ${payload.url} after initial failure.`);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the URL opening IPC with a flag indicating where to open things.