Introduce policy SyncSettings to control sync state #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
gcp
reviewed
Jan 9, 2026
| @@ -204,6 +204,13 @@ EnterprisePoliciesManager.prototype = { | |||
| const policyNames = Object.keys(unparsedPolicies || {}); | |||
|
|
|||
| for (let policyName of policyNames) { | |||
|
|
|||
| #ifdef MOZ_ENTERPRISE | |||
| if (policyName in ["DisableAccounts", "DisableFirefoxAccounts"]) { | |||
Contributor
There was a problem hiding this comment.
policyName = "DisableAccounts";
console.log(policyName in ["DisableAccounts", "DisableFirefoxAccounts"])
Return false.
gcp
reviewed
Jan 9, 2026
| policy-SupportMenu = Add a custom support menu item to the help menu. | ||
| policy-SyncSettings = Enable or disabled Sync and additionally define which data to sync. |
gcp
reviewed
Jan 9, 2026
| "SyncSettings": { | ||
| "type": "object", | ||
| "properties": { | ||
| "SyncEnabled": { |
gcp
reviewed
Jan 9, 2026
| "required": ["Title", "URL"] | ||
| }, | ||
|
|
||
| #ifdef MOZ_ENTERPRISE |
Contributor
There was a problem hiding this comment.
Huh, does this work without marking this somewhere in a moz.build?
gcp
reviewed
Jan 9, 2026
| } | ||
|
|
||
| lazy.log.debug("Force-enable Sync"); | ||
| await this.connectSync(manager); |
Contributor
There was a problem hiding this comment.
Move this after the prefs setting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exemplary policy setting: