feat(nimbus): ingest DAU and its new statistic #12066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewilli
requested review from
jaredlockhart,
yashikakhurana and
freshstrangemusic
as code owners
mikewilli
force-pushed
the
12065-dau-default-guardrail-ingest
branch
from
f83e4f9 to
b06ba85
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
Because - with #12066 we will be ingesting DAU properly alongside DOU - we want to switch from DOU to DAU as the default guardrail in the UI - we still want to show DOU for older experiments that do not have DAU - we no longer care about supporting QCDOU as a highlighted metric for desktop experiments This commit - adds DAU and uses it instead of DOU for highlighted tables - but falls back to using DOU if DAU doesn't exist - removes special-case code for QCDOU in desktop that was added in #9520 Fixes #12065 Note: per @danielkberry, we don't want to display DOU as a secondary metric at all, so we don't. We show either DAU (preferred) or DOU (fallback) in the highlighted metrics tables, but if both are available we only show DAU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
This is step 1 of 2 for #12065
Step 2 will be to update the UI.
/cc @danielkberry